[PATCH] D141323: AMDGPU: Use constant and externally_initialized for block handle

Mon Jan 9 14:20:04 PST 2023

yaxunl accepted this revision as: yaxunl.
yaxunl added a comment.
This revision is now accepted and ready to land.

In D141323#4037724 <https://reviews.llvm.org/D141323#4037724>, @arsenm wrote:

> In D141323#4037723 <https://reviews.llvm.org/D141323#4037723>, @arsenm wrote:
>
>> In D141323#4037714 <https://reviews.llvm.org/D141323#4037714>, @yaxunl wrote:
>>
>>> I doubt this will work. First, this may result in missing symbol in lld. Second, the runtime currently expects *.runtime_handle global symbols having a certain size and will initialize them by copying to them. If this compiler change requires a corresponding runtime change, it should be coordinated with runtime.
>>
>> It does work, this just changes optimizer behavior
>
> Neither the size, name nor linkage changes

Then it should be OK.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141323/new/

https://reviews.llvm.org/D141323