[PATCH] D141323: AMDGPU: Use constant and externally_initialized for block handle

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 14:12:51 PST 2023


arsenm added a comment.

In D141323#4037714 <https://reviews.llvm.org/D141323#4037714>, @yaxunl wrote:

> I doubt this will work. First, this may result in missing symbol in lld. Second, the runtime currently expects *.runtime_handle global symbols having a certain size and will initialize them by copying to them. If this compiler change requires a corresponding runtime change, it should be coordinated with runtime.

It does work, this just changes optimizer behavior


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141323/new/

https://reviews.llvm.org/D141323



More information about the llvm-commits mailing list