[PATCH] D141072: [NVPTX] Work around syntax error in PTX assembly

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

In D141072#4036024 <https://reviews.llvm.org/D141072#4036024>, @ldrumm wrote:

> Slight fly in the ointment: The existing tests exposed that that this implementation is too naive and is renaming things it shouldn't. I'll be back with a more mature implementation. Thanks for the reviews and patience

For what it's worth, we did have a handful of attempts to improve PTX symbol character set compliance in the past, but we've failed to find a much better fix than what we have now.  IIRC, the proposal closest to 'generic' solution was to make back-end responsible for providing the legal character set for the symbols and then make all IT transforms use it, instead of the current implicit assumptions we're relying on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141072/new/

https://reviews.llvm.org/D141072