[PATCH] D141172: [ModuleUtils][KCFI] Set patchable-function-prefix for synthesized functions

[Sami Tolvanen via Phabricator via llvm-commits]

samitolvanen added inline comments.


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/kcfi-offset.ll:1
+;; Test that we set patchable-function-prefix for asan.module_ctor when kcfi-offset is defined.
+
----------------
MaskRay wrote:
> `test/Transforms/KCFI/kcfi-patchable-function-prefix.ll` or a new file is perhaps a better place for this test. It's mainly about kcfi's requirement and less about asan.
That also occurred to me, but the `Transforms/KCFI` directory only contains tests for the KCFI pass, which doesn't support prefix nops, and this test is about `asan.module_ctor` with KCFI, so I thought keeping the test with `AddressSanitizer` tests would be more appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141172/new/

https://reviews.llvm.org/D141172