[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.
Jonas Paulsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 12:30:50 PST 2023
jonpa added a comment.
ping - any opinion on how to best determine the right extension actions for each target? Currently TLI holds variables (ShouldExt.../ShouldSignExt...), but TLI is not available in OMPIRBuilder. As discussed earlier, one option would of course be to provide TLI in OMPIRBuilder, but the alternative that I have found is to have a static function instead that just takes the Triple for each query. I think that would simplify things a bit (if always used) and I imagine it shouldn't be any compile time concern. What do you think?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133949/new/
https://reviews.llvm.org/D133949
More information about the llvm-commits
mailing list