[PATCH] D79140: [ThinLTO] return error instead of crashing on invalid input

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 12:29:04 PST 2023


MaskRay added inline comments.


================
Comment at: lld/test/ELF/stale-profile-error.ll:1
+; RUN: split-file %s %t
+; RUN: llvm-as %t/size1.ll -o %t/size1.bc
----------------
MaskRay wrote:
> Move this to `lto/` and add `REQUIRES: x86`
Ideally use a `llvm/test/ThinLTO` or `llvm/test/LTO`. This test isn't so related to lld https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79140/new/

https://reviews.llvm.org/D79140



More information about the llvm-commits mailing list