[PATCH] D141185: [MemorySSA] Don't check def set when cloning memoryaccesses

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:1764
-    // FIXME: Would Def value always be consistent after transforms?
-    assert(Def == DefCheck && "Invalid template");
     if (!Def && Use != UseCheck) {
----------------
nikic wrote:
> We could do something like `assert(Def == DefCheck || !DefCheck)`, to check that we only reduce, but not increase possible accesses. (Though I suspect that we'll hit cases like that as well...)
+1 to add this check now.
If we encounter the opposite it'll be worth understanding how something became obfuscated enough to miss that the instruction cannot write.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141185/new/

https://reviews.llvm.org/D141185