[PATCH] D79140: [ThinLTO] return error instead of crashing on invalid input

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks for picking this up. Question on the test.



================
Comment at: lld/test/ELF/stale-profile-error.ll:8
+; Test module flags error messages.
+; CHECK: linking module flags 'foo': IDs have conflicting values in '{{.*}}size2.bc' and 'ld-temp.o'
+
----------------
Does this test fail without the change in this patch? It seems the main difference is that it dies more nicely with an error rather than a crash with backtrace, so it looks like this test would also pass without this change. Is there a way to make it fail with the crash?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79140/new/

https://reviews.llvm.org/D79140