[PATCH] D140560: AMDGPU: Fix broken opaque pointer handling in printf pass

Mon Jan 9 06:17:21 PST 2023

saghir added a comment.

In D140560#4032567 <https://reviews.llvm.org/D140560#4032567>, @arsenm wrote:

> In D140560#4031989 <https://reviews.llvm.org/D140560#4031989>, @arsenm wrote:
>
>> In D140560#4030857 <https://reviews.llvm.org/D140560#4030857>, @saghir wrote:
>>
>>> Hi, this seems to be causing our bots to fail. One example is https://lab.llvm.org/buildbot/#/builders/231/builds/6915. Can you please take a look? Thanks!
>>
>> I have a patch ready for this, need to write some more tests for it
>
> Try 40078a6b713730ffc164d4c0733d26352eb1e236 <https://reviews.llvm.org/rG40078a6b713730ffc164d4c0733d26352eb1e236>

Thanks for taking a look. Your patch seems to have fixed the error seen before but it fails at a later check now:

  /llvm/test/CodeGen/AMDGPU/opencl-printf.ll:1874:13: error: GCN-NEXT: expected string not found in input
  ; GCN-NEXT: store i32 1953722977, ptr addrspace(1) [[PRINTBUFFPTRCAST]], align 4

Logs can be found here: https://lab.llvm.org/buildbot/#/builders/231/builds/7035/steps/6/logs/FAIL__LLVM__opencl-printf_ll

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140560/new/

https://reviews.llvm.org/D140560