[PATCH] D141275: [AArch64] Sink to umull if we know tops bits are zero.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 05:34:14 PST 2023
dmgreen added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14092
+ // Is it profitable to sink if we found two of the same type of extends.
+ return !Ops.empty() && (NumSExts == 2 || NumZExts == 2);
}
----------------
samtebbs wrote:
> Would an early return within the loop in the case of `NumSExts > 2 && NumZExts > 2` make sense?
I'm working under the assumption that a mul can only have 2 operands. The loop is just checking both of them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141275/new/
https://reviews.llvm.org/D141275
More information about the llvm-commits
mailing list