[PATCH] D141256: [DAGCombine]Don't check for Undef/Poison if the node is deleted

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14356
+    return SDValue();
+  }
+  else{
----------------
RKSimon wrote:
> (style) early out instead of a if-else chain
> ```
> if(N0.getOpcode() == ISD::DELETED_NODE)
>   return SDValue()
> // NOTE: this strips poison generating flags.
> SDValue R = DAG.getNode(N0.getOpcode(), SDLoc(N0), N0->getVTList(), Ops);
> ```
Can you confirm that the DELETED_NODE is appearing due to the UpdateNodeOperands call above (sorry you didn't generate the diff with context so I can't point to it)

I really need to step through the debugger myself, but can't right now :( 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141256/new/

https://reviews.llvm.org/D141256