[PATCH] D138500: [RISCV] Change the return type of getStreamer() to support the use of overloading and other functions in RISCVELFStreamer.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 03:52:20 PST 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM. Would have been easier to review if a separate NFC commit did the change putting the RISCVELFStreamer declaration in RISCVELFStreamer.h.

The change is simple enough I don't feel I need to insist on splitting it up prior to committing (other reviewers might feel differently though). If not splitting, please update the commit description to note how the RISCVELFStreamer declaration was moved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138500/new/

https://reviews.llvm.org/D138500



More information about the llvm-commits mailing list