[PATCH] D139516: [XCOFF] handle the toc-data for object file generation.

Mon Jan 9 03:50:30 PST 2023

shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.

Looks right now. Thanks for adding this support.

================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:626
+    if (SymASec->getCSectType() == XCOFF::XTY_ER) {
+      FixedValue = 0;
+    } else {
----------------
Can we add comments here like: "For non toc-data external symbols, R_TOC type relocation will relocate to data symbols that have XCOFF::XTY_SD type csect. For toc-data external symbols, R_TOC type relocation will relocate to data symbols that have XCOFF_ER type csect. For XCOFF_ER kind symbols, there will be no TOC entry for them, so the FixedValue should always be 0."?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139516/new/

https://reviews.llvm.org/D139516