[PATCH] D141103: [WebAssembly] Ensure 'end_function' in functions

Mon Jan 9 03:41:53 PST 2023

asb added a comment.

In D141103#4035864 <https://reviews.llvm.org/D141103#4035864>, @sbc100 wrote:

> I wonder if its too late to change the requirement such that `.functype` should always come before the label?  This would make the code simpler and the assembly format more consistent maybe?

I'd hope there's still a fair amount of freedom for evolving this text format...but I also don't know if anyone is relying on it. Do we know of any wasm projects at all that use LLVM's assembly format for more than the odd `inline asm`.

I don't have the link to hand right now, but I seem to remember we'd thought about moving to a different marker for the start of a function, as the single-pass parser requires `.functype` declarations for all functions to be emitted up-front, leading to the change I introduced that printed all such declarations at the top of the file as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141103/new/

https://reviews.llvm.org/D141103