[PATCH] D141273: Fix build when LLVM_BUILTIN_TARGETS is not set

Yi Kong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 03:37:50 PST 2023


kongyi created this revision.
kongyi added reviewers: smeenai, phosek.
Herald added a project: All.
kongyi requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If LLVM_BUILTIN_TARGETS is not set, no OS specific variants will be created, causing CMake build failure. Depend on the generic `builtins` target if LLVM_BUILTIN_TARGETS is not set.


https://reviews.llvm.org/D141273

Files:
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -421,7 +421,11 @@
 
     foreach(name ${LLVM_RUNTIME_TARGETS})
       if(builtins_dep)
-        set(builtins_dep_name "${builtins_dep}-${name}")
+        if (LLVM_BUILTIN_TARGETS)
+          set(builtins_dep_name "${builtins_dep}-${name}")
+        else()
+          set(builtins_dep_name ${builtins_dep})
+        endif()
       endif()
       runtime_register_target(${name} ${name}
         DEPENDS ${builtins_dep_name})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141273.487372.patch
Type: text/x-patch
Size: 597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230109/8d67ac9c/attachment.bin>


More information about the llvm-commits mailing list