[PATCH] D110450: [LLD] Remove global state in lld/COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

This patch broke one case for me - it's reproducible by improving one of the existing testcases like this:

  diff --git a/lld/test/COFF/export-all-lto.ll b/lld/test/COFF/export-all-lto.ll
  index 13620e11d9b9..8d54b981a104 100644
  --- a/lld/test/COFF/export-all-lto.ll
  +++ b/lld/test/COFF/export-all-lto.ll
  @@ -2,9 +2,10 @@
   
   ; RUN: llvm-as %s -o %t.bc
   
  -; RUN: lld-link -lldmingw -dll -out:%t.dll %t.bc -noentry -output-def:%t.def
  +; RUN: lld-link -lldmingw -dll -out:%t.dll %t.bc -noentry -output-def:%t.def -implib:%t.lib
   ; RUN: llvm-readobj --coff-exports %t.dll | grep Name: | FileCheck %s
   ; RUN: cat %t.def | FileCheck --check-prefix=IMPLIB %s
  +; RUN: llvm-nm %t.lib | FileCheck --check-prefix=IMPLIB-SYMS %s
   
   ; CHECK: Name: MyComdatFunc
   ; CHECK: Name: MyExtData
  @@ -14,6 +15,12 @@
   ; IMPLIB: MyExtData @2 DATA
   ; IMPLIB: MyLibFunc @3{{$}}
   
  +; IMPLIB-SYMS: 00000000 T MyComdatFunc
  +; IMPLIB-SYMS: 00000000 T __imp_MyComdatFunc
  +; IMPLIB-SYMS: 00000000 D __imp_MyExtData
  +; IMPLIB-SYMS: 00000000 T MyLibFunc
  +; IMPLIB-SYMS: 00000000 T __imp_MyLibFunc
  +
   target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
   target triple = "x86_64-w64-windows-gnu"
   

@aganea How do you want to go about fixing this; should I revert the patch and land this test improvement separately, so that this can be relanded with the test in place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110450/new/

https://reviews.llvm.org/D110450