[PATCH] D141220: [TableGen][SourceMgr] Correctly append filename to include directories

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 9 02:17:00 PST 2023


zero9178 added a comment.

In D141220#4035624 <https://reviews.llvm.org/D141220#4035624>, @gribozavr2 wrote:

> Sorry, I'm reverting this change because it introduced a behavior change.
>
> Previously, the function tried to open the file `Filename` starting from the current working directory. Now it tries to open `IncludedFile` starting from the current working directory, and if that fails, searches for `Filename` in the include path.

I should be sorry not you! This was an obvious oversight from me.

I have pushed a commit to fix this, hope I am not racing with your revert commit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141220/new/

https://reviews.llvm.org/D141220



More information about the llvm-commits mailing list