[PATCH] D141134: [NFC] Only expose getXXXSize functions in TypeSize
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 9 01:36:24 PST 2023
sdesmalen added a comment.
In D141134#4035501 <https://reviews.llvm.org/D141134#4035501>, @gchatelet wrote:
> sdesmalen@ do you feel strongly about the `getXXXSize` version of the functions?
> I tend to agree with courbet@ that `getXXXValue` is more correct (semantically speaking). Also it makes the implementation simpler.
I agree that having one interface for the same thing is better than two, so dropping the `getXXXSize()` interfaces in favour of `getValue()` makes sense to me. Thanks for checking!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141134/new/
https://reviews.llvm.org/D141134
More information about the llvm-commits
mailing list