[PATCH] D141053: [SwiftError] Use IMPLICIT_DEF as a definition for unreachable VReg uses

[Filipp Zhinkin via Phabricator via llvm-commits]

fzhinkin added inline comments.


================
Comment at: llvm/lib/CodeGen/SwiftErrorValueTracking.cpp:266
+
+    assert(std::find(RPOT.begin(), RPOT.end(), UseBB) == RPOT.end() &&
+           "Reachable block has VReg upward use without definition.");
----------------
compnerd wrote:
> Should this be an expensive assert?
Thanks for suggestion, fixed.


================
Comment at: llvm/test/CodeGen/AArch64/swift-error-unreachable-use.ll:1
+; RUN: llc < %s
+;
----------------
compnerd wrote:
> Please expand this into three explicit invocations:
> 
> ```
> llc -mtriple aarch64-unknown-windows-msvc %s -filetype asm -o - | FileCheck %s
> llc -mtriple aarch64-unknown-linux-gnu %s -filetype asm -o - | FileCheck %s
> llc -mtriple aarch64-apple-macosx10.15 %s -filetype asm -o - | FileCheck %s
> ```
> 
> The test should actually validate that the output is correct.
Updated the test, thanks for suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141053/new/

https://reviews.llvm.org/D141053