[PATCH] D141258: [AArch64] Fix crash for expandMOVImm

[Allen zhong via Phabricator via llvm-commits]

Allen created this revision.
Allen added reviewers: zatrazz, efriedma.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
Allen requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix https://github.com/llvm/llvm-project/issues/59892


https://reviews.llvm.org/D141258

Files:
  llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
  llvm/test/CodeGen/AArch64/const-isel.ll


Index: llvm/test/CodeGen/AArch64/const-isel.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/const-isel.ll
@@ -0,0 +1,16 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-none-linux-gnu -fast-isel -verify-machineinstrs < %s | FileCheck %s --check-prefix=FISEL
+
+define i53 @PR59892 () {
+; FISEL-LABEL: PR59892:
+; FISEL:       // %bb.0:
+; FISEL-NEXT:    mov x8, #47668
+; FISEL-NEXT:    movk x8, #4645, lsl #16
+; FISEL-NEXT:    movk x8, #58741, lsl #32
+; FISEL-NEXT:    movk x8, #1, lsl #48
+; FISEL-NEXT:    orr x9, x8, #0x2
+; FISEL-NEXT:    mul x0, x9, x8
+; FISEL-NEXT:    ret
+  %a = mul nsw i53 533765955107380, 533765955107382
+  ret i53 %a
+}
Index: llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
+++ llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
@@ -340,7 +340,7 @@
     return;
   }
 
-  assert(BitSize == 64 && "All 32-bit immediates can be expanded with a"
+  assert(BitSize > 32 && "All 32-bit immediates can be expanded with a"
                           "MOVZ/MOVK pair");
 
   // Try other two-instruction sequences.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141258.487301.patch
Type: text/x-patch
Size: 1279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230109/8684d11c/attachment.bin>