[PATCH] D140599: AMDGPU: Promote array alloca if used by memmove/memcpy

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 8 18:32:19 PST 2023


ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:611
+            Type *VecPtrTy = VectorTy->getPointerTo(Alloca->getAddressSpace());
+            Value *BitCast = Builder.CreateBitCast(Alloca, VecPtrTy);
+            Value *VecValue = Builder.CreateLoad(VectorTy, BitCast);
----------------
arsenm wrote:
> No reason to care about type pointers anymore
Our graphics compiler has not fully switched to opaque pointers yet. @foad am I right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140599/new/

https://reviews.llvm.org/D140599



More information about the llvm-commits mailing list