[PATCH] D136392: [Bazel] Use `LLVM_VERSION` from `llvm/CMakeLists.txt`

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni marked an inline comment as done.
chapuni added a comment.

Thank you @GMNGeoffrey for the comment and I am sorry for the delay.

> Are there practical portability concerns about doing this in Python? I'm not aware of a platform where Bazel runs that Python doesn't.

It is my preference. Still I think that external tools may be avoided as possible in repository rules.
At the moment I don't use other platforms like Windows. I haven't met any portability issues but I would like to prevent them.
In my experiences, Python has not been easy for portability, configurability, version and platforms.

(I could use platform-specific tools to implement platform-specific functionality. For example, to import repositories from *.deb or installed deb packages)

FYI, the prototype was using sed(1). It was simpler but I gave it up due to portability concern.

I know my implementation by Starlark is not smart but I expect it may be removed in the near future when we could introduce the centralized version database file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136392/new/

https://reviews.llvm.org/D136392