[PATCH] D139907: [FuzzMutate] RandomIRBuilder has more source and sink type now.

[Peter Rong via Phabricator via llvm-commits]

Peter marked an inline comment as done.
Peter added inline comments.


================
Comment at: llvm/lib/FuzzMutate/RandomIRBuilder.cpp:128
+      SmallVector<Argument *, 4> Args;
+      for (uint64_t i = 0; i < F->arg_size(); i++) {
+        Args.push_back(F->getArg(i));
----------------
arsenm wrote:
> Args(F.args()) or Args(F.arg_begin, F.arg_end()) should work to do this in the constructor
As we have discussed before, both methods you mentioned gives a reference range. While `makeSampler` down below doesn't work well with references as it declared `std::remove_reference_t`, implicitly calling a copy constructor when sampling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139907/new/

https://reviews.llvm.org/D139907