[PATCH] D141191: [CMake][LoongArch] Add LoongArch to LLVM_ALL_TARGETS so it is built by default

Sat Jan 7 04:23:14 PST 2023

rengolin added reviewers: lattner, echristo, asl, t.p.northover, RKSimon, probinson, iliya-diyachkov, myhsu, tstellar.
rengolin added a subscriber: tstellar.
rengolin added a comment.

Thank you for your continued contributions, @SixWeining!

Adding some key people and other target owners, including non-default ones. :)

As discussed in the RFC <https://discourse.llvm.org/t/rfc-promoting-the-loongarch-backend-from-experimental-to-official/67506>, the LoongArch target has completed the requirements from the policy.

The only minor issues raised were:

- We're at the release branch time, so not sure we want this before branch (and risk bug-fixes in dot releases), or after the branch (and wait another 6 months for the target to be "live").
- The buildbot is only 10 days green (during holidays), while the policy states 3 months.

The target has been stable and is working on the test-suite and a large body of upstream projects for a while, so the probability of serious bugs is minimal. And if there is a bug, it will be only on their target, not the rest of LLVM.

The delay in setting up a buildbot was due to the holiday period and the time it takes to approve and start a builder in Buildbot.

So, I'm happy with whatever the consensus is, but I personally feel they're ready for prime time.

Since this is a big decision, please wait for a number of people to approve. Coordinate with @tstellar about the release branch.

I'll let other people "approve" this, as I've been too involved in the process and don't want to bias the review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141191/new/

https://reviews.llvm.org/D141191