[PATCH] D140830: [AVR] correctly declare __do_copy_data and __do_clear_bss

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 18:31:07 PST 2023


benshi001 added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/no-copy-data.ll:2
+; RUN: llc < %s -march=avr | FileCheck %s
+
+; CHECK-NOT: .globl __do_copy_data
----------------
aykevl wrote:
> benshi001 wrote:
> > add `CHECK: .globl __do_clear_bss`
> `__do_clear_bss` isn't set either: both globals aren't in `.bss` (one is in a different section, the other is not defined but declared).
> I have added a new global to be able to test this. Do you think this is a good solution?
That is fine. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140830/new/

https://reviews.llvm.org/D140830



More information about the llvm-commits mailing list