[PATCH] D140649: [AArch64][SelectionDAG] Eliminates redundant zero-extension for 32-bit popcount

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 17:36:23 PST 2023


Allen added a comment.

In D140649#4030875 <https://reviews.llvm.org/D140649#4030875>, @dmgreen wrote:

> Could it just use a FMOVWSr?
>
>   def : Pat<(v8i8 (bitconvert (i64 (zext GPR32:$Rn)))),
>             (SUBREG_TO_REG (i32 0), (f32 (FMOVWSr GPR32:$Rn)), ssub)>;
>
> That way we know the top bits will be zero from the FMOVWSr, and so the SUBREG_TO_REG will correctly assert the top bits are zero.

Thanks, apply your comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140649/new/

https://reviews.llvm.org/D140649



More information about the llvm-commits mailing list