[PATCH] D141152: AMDGPU: Fix opaque pointer and other bugs in printf of constant strings

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:425
+      } else if (isa<PointerType>(ArgType)) {
         if (shouldPrintAsStr(OpConvSpecifiers[ArgCount - 1], ArgType)) {
+          APInt StrOffset(TD->getIndexTypeSizeInBits(ArgType), 0);
----------------
Can you replace this code with getConstantStringInfo()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141152/new/

https://reviews.llvm.org/D141152