[PATCH] D141156: Merge lines in print-changed by showing simple changes in place in the line

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 13:18:47 PST 2023


jamieschmeiser created this revision.
jamieschmeiser added a reviewer: aeubanks.
Herald added a subscriber: hiraditya.
Herald added a project: All.
jamieschmeiser requested review of this revision.
Herald added a project: LLVM.

Relative simple changes result in a line being flagged as changed, showing the entire line in both red and green in the cdiff and dot-cfg outputs.
For example, an unnamed variable being removed results in all the subsequent variables being renamed, showing all lines containing these variables
in red or green and much time can be spent just verifying that the only change is the variable.  Similar things happen when attributes change.
Where possible, merge these changes into a single line, showing the colourized change in line with the common part shown in black rather
than showing the entire line twice, once in red and once in green.  Also flag such lines with a (red) asterisk in print-changed=(c)diff to aid identifying such lines.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141156

Files:
  llvm/lib/Passes/StandardInstrumentations.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141156.486972.patch
Type: text/x-patch
Size: 10425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230106/70a69190/attachment.bin>


More information about the llvm-commits mailing list