[PATCH] D140815: [AVR] Fix incorrect decoding of RJMP and RCALL

Fri Jan 6 13:05:46 PST 2023

aykevl added a comment.

In D140815#4021441 <https://reviews.llvm.org/D140815#4021441>, @benshi001 wrote:

> Since llvm-objdump decodes all address offsets of `rjmp`/`rcall` (before linking) to 0, so you can see those zeros in `llvm/test/MC/AVR/inst-rjmp.s`, which are not affected.
>
> llvm-objdump only affects address offsets of `rjmp`/`rcall` that are after linking, so we have to test them in the lld tests.

Hmm, yeah that's a problem.
@MaskRay do you have an idea how to properly test this? I don't like moving these tests into lld (it's a separate subproject), but the alternative seems to be to use a binary file to test against which isn't great either.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140815/new/

https://reviews.llvm.org/D140815