[PATCH] D141082: [lld] Prevent assertions for aliases to weak_def_can_be_hidden symbols

Fri Jan 6 11:25:05 PST 2023

paulkirth added a comment.

In D141082#4032085 <https://reviews.llvm.org/D141082#4032085>, @int3 wrote:

> Hm interesting. I'm actually wondering if we are handling these aliases correctly in general.

That's actually one of the reasons I made the patch. I'm not the most familiar w/ Mach-O semantics, but I believe its perfectly fine to have an alias to a `weak` or `weak_def_can_be_hidden` symbol. I wanted to double check with the experts that 1) that assumption is correct, and 2) if there is broader problem than just a missing case in an assertion.

> I wasn't aware that there were section-based aliases; `alias-symbols.s` only tests the non-section-based types.

hmm, you know I just did the simple thing and added the test here since it used `weak_def_can_be_hidden` already. Do you think we should move this test into alias.s or maybe somewhere else?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141082/new/

https://reviews.llvm.org/D141082