[PATCH] D139590: [RegAllocFast] Handle new debug values for spills

[Josh Stone via Phabricator via llvm-commits]

cuviper added a comment.

I had changed my commit message to reflect that we're now skipping these, instead of handling them, but `arc amend` changed it back when I only meant to update the review status. I suppose I should have updated the title+summary here too -- sorry about that! For posterity, here's what I wanted it to say, dug out of my reflog:

  [RegAllocFast] Skip debug value lists for spills
  
  New debug values for spills get inserted after the place where the spill
  happens, which means they won't be reached by the reverse traversal of
  basic block instructions. This would crash or fail assertions if they
  contained any virtual registers to be replaced. We don't have enough
  support for tracking operands of debug values to properly update these,
  so just skip DBG_VALUE_LIST for spills. This only should only arise for
  the unusual case of optimized IR passed to O0 codegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139590/new/

https://reviews.llvm.org/D139590