[PATCH] D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D140087#4028903 <https://reviews.llvm.org/D140087#4028903>, @lebedev.ri wrote:

> In D140087#4019772 <https://reviews.llvm.org/D140087#4019772>, @goldstein.w.n wrote:
>
>> In D140087#4019617 <https://reviews.llvm.org/D140087#4019617>, @lebedev.ri wrote:
>>
>>> Please be sure to precommit the test changes before committing the change itself.
>>
>> You want the new tests `invalid_add31` / `invalid_sub31` split into a seperate commit?
>
> In general, when adding new tests, if the new tests do not crash the opt/llc before the change,
> they should be committed first, so the change shows the diff of CHECK lines, not just the new CHECK lines.

The test dependency have landed https://github.com/llvm/llvm-project/commit/a698790c51ec2804c3a7ba4c59438e7816690ea2
is this good to go?

>>> Looks good to me now. Thanks!




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140087/new/

https://reviews.llvm.org/D140087