[PATCH] D140901: [DebugInfo] Do not delete debug intrinsics with empty metadata operands

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Thanks for the review. I factored out a part of this into D141140 <https://reviews.llvm.org/D141140> so it can be committed before this patch (which I agree needs more time to receive others' reviews - I'll open a fresh discourse thread soon).



================
Comment at: llvm/lib/IR/Verifier.cpp:6028-6032
             DAI->getRawAssignID());
-    CheckDI(isa<ValueAsMetadata>(DAI->getRawAddress()),
-            "invalid llvm.dbg.assign intrinsic address)", &DII,
-            DAI->getRawAddress());
+    const auto *RawAddr = DAI->getRawAddress();
+    CheckDI(
+        isa<ValueAsMetadata>(RawAddr) ||
+            (isa<MDNode>(RawAddr) && !cast<MDNode>(RawAddr)->getNumOperands()),
----------------
Factored out this part into another patch that comes with a test: D141140


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140901/new/

https://reviews.llvm.org/D140901