[PATCH] D141088: [AMDGPU] Combine redundant Asm64 and AsmVOP3DPPBase. NFC
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 6 06:43:54 PST 2023
Joe_Nash marked an inline comment as done.
Joe_Nash added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:2583
HasModifiers, DstVT>.ret;
- field string AsmVOP3DPP = getAsmVOP3DPP<AsmVOP3DPPBase>.ret;
- field string AsmVOP3DPP16 = getAsmVOP3DPP16<AsmVOP3DPPBase>.ret;
- field string AsmVOP3DPP8 = getAsmVOP3DPP8<AsmVOP3DPPBase>.ret;
+ field string Asm64 = AsmVOP3Base;
+ field string AsmVOP3P = getAsmVOP3P<NumSrcArgs, HasModifiers, HasClamp, HasOpSel>.ret;
----------------
rampitec wrote:
> Looks like you can remove getAsm64 now (and modify comment mentioning it at getAsm32).
You're right, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141088/new/
https://reviews.llvm.org/D141088
More information about the llvm-commits
mailing list