[PATCH] D141090: [InstCombine] Canonicalize (A & B_Pow2) eq/ne B_Pow2 patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 06:02:02 PST 2023


spatel accepted this revision.
spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-and-shift.ll:509
 
 define i1 @slt_and_shl_one(i8 %x, i8 %y) {
 ; CHECK-LABEL: @slt_and_shl_one(
----------------
I like to have "negative test" comments on examples like these, so it's clear that if they somehow do change in the future, that wasn't supposed to happen.

The transform could be extended to at least some non-equality predicates in a follow-up patch:
https://alive2.llvm.org/ce/z/eig49D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141090/new/

https://reviews.llvm.org/D141090



More information about the llvm-commits mailing list