[PATCH] D140702: [exegesis] "Skip codegen" dry-run mode

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 05:42:37 PST 2023


gchatelet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkResult.h:37-42
+enum class BenchmarkPhaseSelectorE {
+  StopBeforeAllCodegen,
+  StopBeforeFullCodegen,
+  StopBeforeMeasurements,
+  Measure,
+};
----------------
lebedev.ri wrote:
> I just realized, we only changed the user-facing side,
> but kept the implementation detail. Is that fine?
I fixed it in https://github.com/llvm/llvm-project/commit/bb37cab8a564c0ee1a764e5464f7c8f41a86e504


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140702/new/

https://reviews.llvm.org/D140702



More information about the llvm-commits mailing list