[PATCH] D141057: Introduce and use codegen::createTargetMachineForTriple()

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.h:188
+/// the TargetOptions. For example, "opt" uses this functon to infer the default
+/// DataLayout for a given triple.
+Expected<std::unique_ptr<TargetMachine>>
----------------
nit: Drop last part of the comment (which is not part of this patch).


================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:725
+                                      CodeGenOpt::Level OptLevel) {
+  Triple TheTriple(TargetTriple);
+  std::string Error;
----------------
Some of the uses called `Triple::normalize()`, but this doesn't. Is that a problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141057/new/

https://reviews.llvm.org/D141057