[PATCH] D138814: [InstCombine] Combine a/lshr of add -> (a + b < a)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 05:12:38 PST 2023


arsenm added a comment.

In D138814#4031097 <https://reviews.llvm.org/D138814#4031097>, @Pierre-vh wrote:

> Rebased tests for proper diff
>
> Before I remove the known bits part and replace it with zext matching I would like @arsenm/@foad to give their opinions too

I think splitting the known bits part as a second step makes sense. The general case multiplies your potential bug surface so I think it's usually better to do this in 2 steps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138814/new/

https://reviews.llvm.org/D138814



More information about the llvm-commits mailing list