[PATCH] D139842: [compiler-rt][X86] add half <-> x86_fp80 conversion builtins

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 03:57:53 PST 2023


t.p.northover updated this revision to Diff 486806.
t.p.northover added a comment.

Tests weren't running on Darwin properly for some reason so things were a bit broken there.

- `__truncxfhf2` had wrong (hard-float) ABI because it hardcoded `_Float16` as the return type.
- The tests were copying 16 bytes of a 10-byte  `long double` because `sizeof(long double)` is weird.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139842/new/

https://reviews.llvm.org/D139842

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/extendhfxf2.c
  compiler-rt/lib/builtins/fp_extend.h
  compiler-rt/lib/builtins/fp_extend_impl.inc
  compiler-rt/lib/builtins/fp_lib.h
  compiler-rt/lib/builtins/fp_trunc.h
  compiler-rt/lib/builtins/fp_trunc_impl.inc
  compiler-rt/lib/builtins/truncxfhf2.c
  compiler-rt/test/builtins/Unit/extendhfxf2_test.c
  compiler-rt/test/builtins/Unit/fp_test.h
  compiler-rt/test/builtins/Unit/truncxfhf2_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139842.486806.patch
Type: text/x-patch
Size: 21021 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230106/666d1391/attachment.bin>


More information about the llvm-commits mailing list