[PATCH] D141103: [WebAssembly] Ensure 'end_function' in functions

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 02:23:11 PST 2023


sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:880
+        //    without encountering a .functype directive after the label.
+        if (CurrentState != FunctionLabel) {
+          // This .functype indicates a start of a function.
----------------
It seems like if this `.functype` is the start of a function this condition should be `CurrentState == FunctionLabel`, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141103/new/

https://reviews.llvm.org/D141103



More information about the llvm-commits mailing list