[PATCH] D139601: [LoopVectorize] Clear cache of `LoopAccessInfoManager`

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 00:56:10 PST 2023


fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks! Just a few additional small comments for the test .



================
Comment at: llvm/test/Transforms/LoopVectorize/X86/pr59319.ll:5
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
I *think* with the vectorization factor forced, the test doesn't need to be X86 specific. I think the triple now could be removed and the test moved out of the X86 directory.

might also be good to include a quick comment in the test that this tests LoopAccessInfo invalidation after LV modifying the IR. Might also be good to include something like `loop-access-info-invalidation` in the test name (in addition to prXXXX)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139601/new/

https://reviews.llvm.org/D139601



More information about the llvm-commits mailing list