[PATCH] D140572: [AVR] Optimize 32-bit shifts: reverse shift + move

[Ben Shi via Phabricator via llvm-commits]

benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1909
+    for (size_t I = 0; I < Regs.size(); I++) {
+      int Idx = I + 1;
+      if (Idx < (int)ShiftRegs.size()) {
----------------
a tiny suggestion, this can be `const int ShiftRegsIdx = I + 1;` .


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:1969
+    for (int I = Regs.size() - 1; I >= 0; I--) {
+      int Idx = I - (Regs.size() - ShiftRegs.size()) - 1;
+      if (Idx >= 0) {
----------------
a tiny suggestion, this can be `const int ShiftRegsIdx = I - (Regs.size() - ShiftRegs.size()) - 1;` .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140572/new/

https://reviews.llvm.org/D140572