[compiler-rt] f547c17 - [LSAN][NFC] Removed FinishThreadLocked from the LSAN interface.

Kirill Stoimenov via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 16:28:52 PST 2023


Author: Kirill Stoimenov
Date: 2023-01-06T00:28:40Z
New Revision: f547c173f25f2155080d1f33ec35e8103692883f

URL: https://github.com/llvm/llvm-project/commit/f547c173f25f2155080d1f33ec35e8103692883f
DIFF: https://github.com/llvm/llvm-project/commit/f547c173f25f2155080d1f33ec35e8103692883f.diff

LOG: [LSAN][NFC] Removed FinishThreadLocked from the LSAN interface.

It is only used in the LSAN specific part.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D140109

Added: 
    

Modified: 
    compiler-rt/lib/lsan/lsan_common.h
    compiler-rt/lib/lsan/lsan_fuchsia.cpp
    compiler-rt/lib/lsan/lsan_thread.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/lsan/lsan_common.h b/compiler-rt/lib/lsan/lsan_common.h
index 7827370aa8bb..089aa10155a0 100644
--- a/compiler-rt/lib/lsan/lsan_common.h
+++ b/compiler-rt/lib/lsan/lsan_common.h
@@ -108,7 +108,6 @@ void ForEachExtraStackRange(tid_t os_id, RangeIteratorCallback callback,
 
 void RunCallbackForEachThreadLocked(__sanitizer::ThreadRegistry::ThreadCallback cb,
                                     void *arg);
-void FinishThreadLocked(u32 tid);
 
 //// --------------------------------------------------------------------------
 //// Allocator prototypes.

diff  --git a/compiler-rt/lib/lsan/lsan_fuchsia.cpp b/compiler-rt/lib/lsan/lsan_fuchsia.cpp
index 1cb0fc6491e8..1bcb748e7d2a 100644
--- a/compiler-rt/lib/lsan/lsan_fuchsia.cpp
+++ b/compiler-rt/lib/lsan/lsan_fuchsia.cpp
@@ -110,7 +110,7 @@ void __sanitizer_thread_create_hook(void *hook, thrd_t thread, int error) {
   // On success, there is nothing to do here.
   if (error != thrd_success) {
     // Clean up the thread registry for the thread creation that didn't happen.
-    FinishThreadLocked(tid);
+    GetLsanThreadRegistryLocked()->FinishThread(tid);
   }
 }
 

diff  --git a/compiler-rt/lib/lsan/lsan_thread.cpp b/compiler-rt/lib/lsan/lsan_thread.cpp
index 7309b831c7e8..d04d9057b71b 100644
--- a/compiler-rt/lib/lsan/lsan_thread.cpp
+++ b/compiler-rt/lib/lsan/lsan_thread.cpp
@@ -92,8 +92,4 @@ void RunCallbackForEachThreadLocked(
   GetLsanThreadRegistryLocked()->RunCallbackForEachThreadLocked(cb, arg);
 }
 
-void FinishThreadLocked(u32 tid) {
-  GetLsanThreadRegistryLocked()->FinishThread(tid);
-}
-
 }  // namespace __lsan


        


More information about the llvm-commits mailing list