[PATCH] D140933: [LVI] Look through negations when evaluating conditions

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

> In the particular case I was looking at there was a bit of a
> circular dependency where flags computed by cvp were needed
> by instcombine, and incstombine's folding of the negation was
> needed for cvp

You might want to add a PhaseOrdering test to make sure your case keeps working.



================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1169
 
+// Tracks a Value * condition and whether we're intereted in it or its inverse
+typedef PointerIntPair<Value*, 1, bool> CondValue;
----------------
interested


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140933/new/

https://reviews.llvm.org/D140933