[PATCH] D140585: CodingStandards: restrict CamelCase variable names guideline to llvm/clang/clang-tools-extra/polly/bolt

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 14:12:29 PST 2023


dblaikie added a comment.

In D140585#4029712 <https://reviews.llvm.org/D140585#4029712>, @mehdi_amini wrote:

>> I personally don't think the difference in naming is sufficiently valuable to justify this inconsistency (& I think it was a mistake to allow new subprojects with these deviating naming conventions - those should've been fixed before integrating them)
>
> FYI, speaking for MLIR, the only reason it ended up with a different naming convention is because we thought LLVM was about to adopt the proposed new one at the time and we thought we'd avoid a later renaming for this codebase. The intent was to be aligned with LLVM and the current result is more unfortunate than intended.

Ah, that's helpful to understand - thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140585/new/

https://reviews.llvm.org/D140585



More information about the llvm-commits mailing list