[PATCH] D141054: [NVPTX] Set default version of architecture to SM_30, PTX to 6.0.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 11:59:32 PST 2023


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM with few nits.



================
Comment at: llvm/test/CodeGen/NVPTX/sm-version.ll:35
 
-; SM30: .version 3.2
+; SM20: .version 3.2
 ; SM32: .version 4.0
----------------
Please add the checks for SM21 and SM30, too.


================
Comment at: llvm/test/CodeGen/NVPTX/surf-tex.py:2
 # RUN: %python %s --target=cuda --tests=suld,sust,tex,tld4 --gen-list=%t.list > %t-cuda.ll
-# RUN: llc %t-cuda.ll -verify-machineinstrs -o - | FileCheck %t-cuda.ll
-# RUN: %if ptxas %{ llc %t-cuda.ll -verify-machineinstrs -o - | %ptxas-verify %}
+# RUN: llc -mcpu=sm_20 %t-cuda.ll -verify-machineinstrs -o - | FileCheck %t-cuda.ll
+# RUN: %if ptxas %{ llc -mcpu=sm_20 %t-cuda.ll -verify-machineinstrs -o - | %ptxas-verify %}
----------------
We may as well change it to `sm_30`, too. sm_20 is gone for all practical purposes. Even sm_30 is on the way out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141054/new/

https://reviews.llvm.org/D141054



More information about the llvm-commits mailing list