[PATCH] D141074: Avoid converting 64-bit integers to floating point using x87 on Windows

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 11:59:03 PST 2023


lebedev.ri added a comment.

In D141074#4029541 <https://reviews.llvm.org/D141074#4029541>, @craig.topper wrote:

> In D141074#4029537 <https://reviews.llvm.org/D141074#4029537>, @lebedev.ri wrote:
>
>>> only on Windows 32-bit
>>
>> Is the `default precision control` different for 64-bit?
>
> No, but I think we use a different algorithm with a 64-bit cvtsi2ss on 64-bit targets so we don't end up using x87.

I'm mainly asking whether this needs to check for the 32-bit windows specifically, not just that it is windows. Guess not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141074/new/

https://reviews.llvm.org/D141074



More information about the llvm-commits mailing list