[llvm] b4993be - Remove documentation about the Go bindings
Aaron Ballman via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 5 11:49:37 PST 2023
Author: Aaron Ballman
Date: 2023-01-05T14:49:28-05:00
New Revision: b4993bea2907ef132d549fa3f1c9a882f4264470
URL: https://github.com/llvm/llvm-project/commit/b4993bea2907ef132d549fa3f1c9a882f4264470
DIFF: https://github.com/llvm/llvm-project/commit/b4993bea2907ef132d549fa3f1c9a882f4264470.diff
LOG: Remove documentation about the Go bindings
We removed the Go bindings in https://reviews.llvm.org/D135436 but
missed documentation that talks about the bindings.
Added:
Modified:
llvm/docs/CMake.rst
llvm/docs/CodingStandards.rst
llvm/docs/GettingStarted.rst
llvm/docs/ReleaseNotes.rst
llvm/utils/gn/secondary/llvm/test/BUILD.gn
Removed:
################################################################################
diff --git a/llvm/docs/CMake.rst b/llvm/docs/CMake.rst
index 28b6805f12e35..fba7e3f6ff0cc 100644
--- a/llvm/docs/CMake.rst
+++ b/llvm/docs/CMake.rst
@@ -466,7 +466,7 @@ enabled sub-projects. Nearly all of these variable names begin with
is *Debug*.
**LLVM_ENABLE_BINDINGS**:BOOL
- If disabled, do not try to build the OCaml and go bindings.
+ If disabled, do not try to build the OCaml bindings.
**LLVM_ENABLE_DIA_SDK**:BOOL
Enable building with MSVC DIA SDK for PDB debugging support. Available
diff --git a/llvm/docs/CodingStandards.rst b/llvm/docs/CodingStandards.rst
index b6225b9fcaa0a..7a1a24b7a7242 100644
--- a/llvm/docs/CodingStandards.rst
+++ b/llvm/docs/CodingStandards.rst
@@ -102,25 +102,6 @@ For more information about LLVM's data structures and the tradeoffs they make,
please consult `that section of the programmer's manual
<https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task>`_.
-Guidelines for Go code
-----------------------
-
-Any code written in the Go programming language is not subject to the
-formatting rules below. Instead, we adopt the formatting rules enforced by
-the `gofmt`_ tool.
-
-Go code should strive to be idiomatic. Two good sets of guidelines for what
-this means are `Effective Go`_ and `Go Code Review Comments`_.
-
-.. _gofmt:
- https://golang.org/cmd/gofmt/
-
-.. _Effective Go:
- https://golang.org/doc/effective_go.html
-
-.. _Go Code Review Comments:
- https://github.com/golang/go/wiki/CodeReviewComments
-
Mechanical Source Issues
========================
diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst
index c336ba8092d2f..c9eae8504c693 100644
--- a/llvm/docs/GettingStarted.rst
+++ b/llvm/docs/GettingStarted.rst
@@ -902,7 +902,7 @@ share code among the `tools`_.
Contains bindings for the LLVM compiler infrastructure to allow
programs written in languages other than C or C++ to take advantage of the LLVM
infrastructure.
-LLVM project provides language bindings for Go, OCaml and Python.
+LLVM project provides language bindings for OCaml and Python.
``llvm/projects``
-----------------
diff --git a/llvm/docs/ReleaseNotes.rst b/llvm/docs/ReleaseNotes.rst
index 2b8a21be08b4f..30d3d7e5be6af 100644
--- a/llvm/docs/ReleaseNotes.rst
+++ b/llvm/docs/ReleaseNotes.rst
@@ -219,10 +219,6 @@ Changes to the C API
* ``LLVMConstInBoundsGEP`` -> ``LLVMConstInBoundsGEP2``
* ``LLVMAddAlias`` -> ``LLVMAddAlias2``
-Changes to the Go bindings
---------------------------
-
-
Changes to the FastISel infrastructure
--------------------------------------
diff --git a/llvm/utils/gn/secondary/llvm/test/BUILD.gn b/llvm/utils/gn/secondary/llvm/test/BUILD.gn
index 0e5f707836839..363be6bb8830f 100644
--- a/llvm/utils/gn/secondary/llvm/test/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/test/BUILD.gn
@@ -43,19 +43,19 @@ write_lit_config("lit_site_cfg") {
extra_values = [
"BUILD_SHARED_LIBS=0",
- # Only used by the Go bindings tests, or if LLVM_USE_SANITIZER includes
- # asan and the host OS is macOS. The GN build currently never uses
- # LLVM_USE_SANITIZER. (See also CMAKE_CXX_COMPILER in clang/test/BUILD.gn.)
+ # Only used if LLVM_USE_SANITIZER includes asan and the host OS is macOS.
+ # The GN build currently never uses LLVM_USE_SANITIZER. (See also
+ # CMAKE_CXX_COMPILER in clang/test/BUILD.gn.)
"HOST_CC=cc",
- # Only used by the Go bindings tests, or if LLVM_USE_SANITIZER includes
- # lsan and the host OS is macOS. The GN build currently never uses
- # LLVM_USE_SANITIZER. (See also CMAKE_CXX_COMPILER in clang/test/BUILD.gn.)
+ # Only used if LLVM_USE_SANITIZER includes lsan and the host OS is macOS.
+ # The GN build currently never uses LLVM_USE_SANITIZER. (See also
+ # CMAKE_CXX_COMPILER in clang/test/BUILD.gn.)
"HOST_CXX=c++",
- # Only used by the Go bindings tests, and for detecting a 32-bit build
- # and in a belt-and-suspenders check for detecting 32-bit host builds.
- # (That check also checks LLVM_HOST_TRIPLE.)
+ # Only used for detecting a 32-bit build and in a belt-and-suspenders check
+ # for detecting 32-bit host builds. (That check also checks
+ # LLVM_HOST_TRIPLE.)
"HOST_LDFLAGS=",
"LLVM_ENABLE_FFI=0",
More information about the llvm-commits
mailing list