[PATCH] D139603: [llvm-profdata] Add option to cap profile output size

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm

Please wait a bit to see if others have additional comments. Thanks!



================
Comment at: llvm/include/llvm/ProfileData/SampleProfWriter.h:45
+  SampleProfileMap &ProfileMap;
+  size_t OutputSizeLimit;
+
----------------
Perhaps specify that this is in bytes either in the variable name or a comment?


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:1209
+  cl::opt<size_t> OutputSizeLimit(
+      "output-size-limit", cl::init(0), cl::Hidden,
+      cl::desc("Trim cold functions until profile size is below specified "
----------------
I think this is generally useful and we should make it visible. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139603/new/

https://reviews.llvm.org/D139603