[PATCH] D141065: IROutliner: Fix another assert with non-0 alloca addrspaces

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1335
     for (unsigned Jdx = TypeIndex; Jdx < ArgumentSize; Jdx++) {
-      if (Group.ArgumentTypes[Jdx] != PointerType::getUnqual(Output->getType()))
+      if (!isa<PointerType>(Group.ArgumentTypes[Jdx]))
         continue;
----------------
AndrewLitteken wrote:
> What's the reasoning behind removing the check for the type of pointer and making it only care about whether it is a pointer?  There can be multiple sets outputs to an set of extracted function and (as I understand it) the previous check looked checked that the argument type is a pointer to a specific type as well to not encounter errors later on.
Pointer element types are no more and it's not worth thinking about them 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141065/new/

https://reviews.llvm.org/D141065